[
https://issues.apache.org/jira/browse/DERBY-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew McIntyre updated DERBY-2467:
-----------------------------------
Derby Info: (was: [Patch Available])
Hi Ugo,
I took a closer look at the test, a few comments:
- I think a check for the order of the rows for column C3 should be added to
testVirtualMemoryHeap(). The old test 'checked' this by comparing the output of
the order of the rows with a master file, but the test intends to check that
rows are spilled from the hash table to VM to disk and that orders changes
based on whether the rows are in the hashtable for the scan, virtual memory, or
on disk. Please see the comment from the previous test that was output to
System.out. I think this comment should be retained in the new test as well so
the intent of this test method is more clear.
- Stylistically, I would have kept the SQL statements in the test fixtures
instead of as instance variables. It's easier when reading through the test to
understand what is being tested if the text of the SQL that is being executed
is in the test fixture.
- verifyCount could be replaced with calls to assertUpdateCount() from
BaseJDBCTestCase. Similarly, verifyBoolean could be replaced with JUnit's
assertTrue() / assertFalse().
Unchecking patch available. The last two are style issues, I'll be glad to
commit a new patch with only the testVirtualMemoryHeap() issue fixed.
> Convert lang/updateCursor.java to JUnit
> ---------------------------------------
>
> Key: DERBY-2467
> URL: https://issues.apache.org/jira/browse/DERBY-2467
> Project: Derby
> Issue Type: Test
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: DERBY-2467_diff_03_27.txt, DERBY-2467_diff_300307.txt,
> DERBY-2467_stat_03_27.txt, DERBY-2467_stat_300307.txt
>
>
> Convert lang/updateCursor.java to JUnit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
