[ 
https://issues.apache.org/jira/browse/DERBY-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rick Hillegas updated DERBY-2502:
---------------------------------

    Attachment: derby-2502-02.diff

Committed derby-2502-02.diff at subversion revision 525924. This fixes the 
error in XMLTypeAndOpsTest introduced by the previous patch. Touches the 
following files:

M      java/testing/org/apache/derbyTesting/junit/JDBC.java

   Adds a new overload for assertFullResultSet() for callers who don't want to 
close the ResultSet.

M      
java/testing/org/apache/derbyTesting/functionTests/tests/lang/XMLTypeAndOpsTest.java

   Uses the new overload.

The full JUnit suite ran cleanly except for an error in 
GroupByExpressionTest--that error occurs even without this patch:

1) 
testMiscExpressions(org.apache.derbyTesting.functionTests.tests.lang.GroupByExpressionTest)java.sql.SQLException:
 The SELECT list of a grouped query contains at least one invalid expression. 
If a SELECT list has a GROUP BY, the list may only contain valid grouping 
expressions and valid aggregate expressions.  
        at 
org.apache.derby.iapi.error.StandardException.newException(StandardException.java:295)
        at 
org.apache.derby.impl.sql.compile.VerifyAggregateExpressionsVisitor.visit(VerifyAggregateExpressionsVisitor.java:85)
        at 
org.apache.derby.impl.sql.compile.QueryTreeNode.accept(QueryTreeNode.java:660)
        at org.apache.derby.impl.sql.compile.CastNode.accept(CastNode.java:1017)
        at 
org.apache.derby.impl.sql.compile.ResultColumn.accept(ResultColumn.java:1518)
        at 
org.apache.derby.impl.sql.compile.QueryTreeNodeVector.accept(QueryTreeNodeVector.java:158)
        at 
org.apache.derby.impl.sql.compile.SelectNode.bindExpressions(SelectNode.java:544)
        at 
org.apache.derby.impl.sql.compile.DMLStatementNode.bindExpressions(DMLStatementNode.java:227)
        at 
org.apache.derby.impl.sql.compile.DMLStatementNode.bind(DMLStatementNode.java:140)
        at 
org.apache.derby.impl.sql.compile.CursorNode.bindStatement(CursorNode.java:236)
        at 
org.apache.derby.impl.sql.GenericStatement.prepMinion(GenericStatement.java:314)
        at 
org.apache.derby.impl.sql.GenericStatement.prepare(GenericStatement.java:88)
        at 
org.apache.derby.impl.sql.conn.GenericLanguageConnectionContext.prepareInternalStatement(GenericLanguageConnectionContext.java:742)
        at 
org.apache.derby.impl.jdbc.EmbedPreparedStatement.<init>(EmbedPreparedStatement.java:129)
        at 
org.apache.derby.impl.jdbc.EmbedPreparedStatement20.<init>(EmbedPreparedStatement20.java:82)
        at 
org.apache.derby.impl.jdbc.EmbedPreparedStatement30.<init>(EmbedPreparedStatement30.java:63)
        at 
org.apache.derby.jdbc.Driver30.newEmbedPreparedStatement(Driver30.java:93)
        at 
org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(EmbedConnection.java:871)
        at 
org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(EmbedConnection.java:715)
        at 
org.apache.derbyTesting.junit.BaseJDBCTestCase.prepareStatement(BaseJDBCTestCase.java:146)
        at 
org.apache.derbyTesting.functionTests.tests.lang.GroupByExpressionTest.verifyQueryResults(GroupByExpressionTest.java:423)
        at 
org.apache.derbyTesting.functionTests.tests.lang.GroupByExpressionTest.testMiscExpressions(GroupByExpressionTest.java:159)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at 
org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:88)
        at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
        at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
        at junit.extensions.TestSetup.run(TestSetup.java:25)




> Unclosed ResultSets choke JUnit lang _Suite on java 6
> -----------------------------------------------------
>
>                 Key: DERBY-2502
>                 URL: https://issues.apache.org/jira/browse/DERBY-2502
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL, Test
>    Affects Versions: 10.3.0.0
>         Environment: solaris, java 6 build 105, insane+debug jars
>            Reporter: Rick Hillegas
>         Attachments: derby-2502-01.diff, derby-2502-02.diff
>
>
> The lang suite fail for me from UnaryArithmeticParameterTest on. The tests 
> can't drop table T1 because a ResultSet is open. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to