[
https://issues.apache.org/jira/browse/DERBY-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anurag Shekhar updated DERBY-2379:
----------------------------------
Attachment: derby-2379v2.diff
Descriptions of path (derby-2379v2.diff)
Fixed bugs found in Knuth and Narayanan reviews
Removed my code to run tests in encrypted mode instead using the Decorator
method for the same
Enabled jdbcapi/BlobClob4BlobTest, jdbcapi/LobStreamsTest,
jdbcapi/ClobUpdatableReaderTest, jdbc4/LobStreamTest to include testing in
encrypted db.
Fixed Javadoc warning and added throws clause in LOBFile methods
Removed unused varraibles
Removed redundant calls to file.length from read and write methods
Added an exception in case setLength is called with a value longer than the
file length.
About synchronization
I have decided to follow RandomAccessFile models (making this class thread
unsafe). The user of this class has to ensure synchronization which is being
taking care in this case by LOBStreamControl. added a note about it in java doc.
I haven't extended the LOBFile class from StorageRandomAccessFile as doing so
will need empty implimentation of several methods (inherited from parent
interfaces of StorageRandomAccessFile)
there was bug in the test case modification i had done (as Naryanan pointed) so
the bugs knut pointed in his review remained unexposed.All the tests I have
enabled for encrypted mode test most of the new code.
> provide encryption support for temporary files used by lob if the dara base
> is encrypted
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2379
> URL: https://issues.apache.org/jira/browse/DERBY-2379
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.3.0.0
> Environment: all
> Reporter: Anurag Shekhar
> Assigned To: Anurag Shekhar
> Attachments: CosmeticComments_1.txt, derby-2379.diff,
> derby-2379v2.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
