[
https://issues.apache.org/jira/browse/DERBY-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493109
]
Kristian Waagan commented on DERBY-1001:
----------------------------------------
Thanks Kathey and Sunitha for looking at the patch.
It is not yet finished, but I will upload another version shortly.
Regarding the comments:
* I considered deleting the database directories, but couldn't find a utility
to do so. There is one in the org...junit package, but it is package private.
I'll look into adding the functionality, or maybe move the
"deleteDirectory"-method to a public utility class.
* Looking at the EncryptionSuite, I see we currently test three different
algorithms. I'll add a test for each (DES, AES and Blowfish). I'm not sure if
it is worth testing all the different variations (feedback mode, padding). Any
opinions on this in the community?
* We should test a streaming cipher (RC4/ARCFOUR), but Derby does not currently
handle this (see DERBY-2552).
* That the suites-methods are different is a bug. I'll fix them in the next
patch.
regards,
> Rewrite 'store/encryptionKey.sql' to a JUnit test
> -------------------------------------------------
>
> Key: DERBY-1001
> URL: https://issues.apache.org/jira/browse/DERBY-1001
> Project: Derby
> Issue Type: Test
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Kristian Waagan
> Priority: Minor
> Attachments: derby-1001-1a-preliminary.diff,
> derby-1001-1a-preliminary.stat
>
>
> This test has failed on Solaris10 for a long time, due to issues with the
> default security provider on this OS. See DERBY-788 for details.
> I consider rewriting this test as interresting because it allows us to see
> how things can be done in "the JUnit way".
> 1) Run test with multiple encryption algorithms with minimal test code
> duplication.
> 2) Special handling of exceptions for specific providers (PCKS11-Solaris).
> The rewritten test might cause some discussion on how we want to handle the
> issues mentioned above.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
