[
https://issues.apache.org/jira/browse/DERBY-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497268
]
Knut Anders Hatlen commented on DERBY-2674:
-------------------------------------------
I think the patch looks good, Øystein. Some minor comments:
* testIsPoolableOnClosed has this piece of code:
+ psClosed.close();
+ if (psClosed.isPoolable())
+ fail("Should throw exception on closed statement");
Shouldn't this fail if psClosed.isPoolable() returns false as well?
* Couldn't the test*OnClosed methods have used ps instead of creating their own
PreparedStatement? ps seems to be initialized in the setUp() method for each
fixture.
* testSetPoolable and testIsPoolable have code like this (not originally
written by you, only reindented)
+ if (ps.isPoolable())
+ fail("Expected a non-poolable statement");
Perhaps it would be better with assertTrue/assertFalse in these cases?
* Not introduced by you, but I noticed that tearDown() doesn't close ps and s,
and it doesn't set any of the statements to null. Perhaps you could fix that as
well while you're at it? :)
> Stop running jdbc40 tests in the old test framework
> ---------------------------------------------------
>
> Key: DERBY-2674
> URL: https://issues.apache.org/jira/browse/DERBY-2674
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Øystein Grøvlen
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: rmTestPreparedStatementMethods.diff,
> rmTestPreparedStatementMethods.stat
>
>
> Tests in the old jdbc40 test suite are run in the derbyall test suite even if
> all the tests have been converted to Junit and is run as part of the Junit
> All test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
