[ 
https://issues.apache.org/jira/browse/DERBY-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499559
 ] 

V.Narayanan commented on DERBY-2702:
------------------------------------

I integrated this patch with all the dependent patches and ran junit All. There 
were no failures in the
test run.

The following is a small description of the step-by-step procedure adopted 
during the
integration process. I applied the below on a fresh workspace.

1) DERBY-2496 Enabling Blob support for locators is committed. 
   So I did not have to apply any patch for this dependency.
   

2) DERBY-2694 org.apache.derby.impl.drda.DDMWriter uses wrong algorithm to 
avoid 
                             spliting varchar in the middle of a multibyte char.
   Applied the patch attached to this issue (derby-2694.diff)

3) DERBY-2587 Connection.createClob() and Connection.createBlob() need to 
return 
                             locator support enabled LOB objects in the 
NetworkClient

   Part of the patch related to modifying createBlob() to return locator support
   enabled Blobs is already committed.

   I applied ConnectionLocatorWork_v4.diff to the workspace.

   In addition to applying this patch I had to do one more thing. The 
createClob()
   method modified in this patch has been temporarily disabled from sending
   locator enabled Clobs.I had to remove the (&& false) intentional disabling
   that was done.

   I am hoping that I can submit a intermediate patch to remove (&& false)
   between the commit of v4 attached to this issue and 2702 being committed.

   
4) DERBY-2604 Implement Clob support for Locators

   A patch was attached to this issue addressing some bugs found in the
   implementation.

   Applied  ClobLocatorWork_v5.diff to the workspace.

5) DERBY-2702 Enable Clob locator support between NetworkServer and 
NetworkClient and modify tests that
                             experience changed behaviour due to this(enabling 
Clob Locators).

   Applied ClobLocatorWorkTestModifications.diff

6) I then did a 

   ant Clobber && ant all && ant buildjarsclean 

   on the above workspace.

7) The jars obtained from the above build was then used to run junit All.


I had a clean run. No failures were observed.

Pls find the integrated patches attached here for further reference.

Pls note that the integrated patches are *not for commit*.

> Enable Clob locator support between NetworkServer and NetworkClient and 
> modify tests that experience changed behaviour due to this(enabling Clob 
> Locators).
> -----------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2702
>                 URL: https://issues.apache.org/jira/browse/DERBY-2702
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Client
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>         Attachments: ClobLocatorWorkTestModifications.diff, 
> ClobLocatorWorkTestModifications.stat
>
>
> This issue will address enabling locator support for Clobs between the 
> Network Server and the Network Client. In addition to this, the tests that 
> will experience changed behaviour as a result of this will also be fixed 
> here. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to