[ 
https://issues.apache.org/jira/browse/DERBY-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kathey Marsden updated DERBY-2747:
----------------------------------

    Derby Info:   (was: [Patch Available])

Kurt I am having a bit of trouble applying your patch. I get an error that 
Reply.java.orig does not exist.
Did you generate the patch with svn diff?

Looking at the patch without applying, I have the following nits:

I prefer if (actualBytesRead > 0) rather than  if (0 < actualBytesRead).

It would be good to include the jira issue number //DERBY-2747 and a brief 
comment about the change with the changed code.

> Reply incorrectly handles read() returning -1
> ---------------------------------------------
>
>                 Key: DERBY-2747
>                 URL: https://issues.apache.org/jira/browse/DERBY-2747
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client
>    Affects Versions: 10.2.2.0
>            Reporter: Kurt Huwig
>            Priority: Minor
>         Attachments: patch-2747-1.diff
>
>
> If java/client/org/apache/derby/client/net/Reply.java encounters a EOF, i.e. 
> reads -1 then it adds this value to the number of bytes read and prints an 
> error message which reads "-1 bytes read".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to