[ 
https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504582
 ] 

Bernt M. Johnsen commented on DERBY-2730:
-----------------------------------------

ClobUpdateableReader (EmbedClob clob, long pos, long len)  throws an 
SQLException but the javadoc has @throws IOException. Same goes for 
UpdateableBlobStream (i missed it in the previous review).

Also: in both constructors (ClobUpdateableReader and UpdateableBlobStream), you 
do
            SQLException sqle = new SQLException();
            sqle.initCause(ioe);
            throw sqle;
I.e.: an SQLException with no message and no sql state is thrown. I think it 
should have both.


> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, 
> long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2730
>                 URL: https://issues.apache.org/jira/browse/DERBY-2730
>             Project: Derby
>          Issue Type: New Feature
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>             Fix For: 10.3.0.0
>
>         Attachments: GetBinaryStreamImpl_v1.diff, 
> GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, 
> GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, 
> GetBinaryStreamImpl_v2.stat, GetCharacterStreamImpl_v1.diff, 
> GetCharacterStreamImpl_v1.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob 
> interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to