[
https://issues.apache.org/jira/browse/DERBY-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519710
]
Ugo Matrangolo commented on DERBY-2900:
---------------------------------------
Hi Kathey.
Thank you for your review and sorry for the late reply.
I think I resolved all the issues you raised.
>Instead of
>while (rs.next()) {
>//System.out.println(rs.getString(1));
>}
>use JDBC.assertFullResultSet or JDBC.assertSingleValueResultSet to check the
>results.
I think that the meaning of this code is not to check the content of the result
set: it wants only to consume all
the rows in the result.
>Statements created with createStatement() or prepareStatement() do not need to
>be closed. They will be >closed automatically.
Fixed.
>It would be good to have javadoc comments for the methods.
All javadoc from previous tests were borrowed in the actual code.
>For Bug5054 I think the contents of setUp can just be moved donw into the test
>method. testBugBug5054 >can be renamed with just one "Bug"
Fixed.
Please review,
--Ugo
> convert lang\bug5054, lang\bug4356 and lang\bug5052rts to JUnit
> ---------------------------------------------------------------
>
> Key: DERBY-2900
> URL: https://issues.apache.org/jira/browse/DERBY-2900
> Project: Derby
> Issue Type: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2900_diff_180707.txt, DERBY-2900_stat_180707.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
