[
https://issues.apache.org/jira/browse/DERBY-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523274
]
Mamta A. Satoor commented on DERBY-2599:
----------------------------------------
Made a commit in main codeline which just fixes the comments. The revision for
change is 570482. I also migrated this change into 10.3 codeline with revision
570483.
Commit comments are as follows.
Fixed the comments for getDominantTypeServices() method in ValueNodeList. The
comments were using an example of concatenation operation but concatenation
operation does not call this method to find the dominant type of it's 2
operands. Instead, concatenation operator implements it's own simple algorithm
in ConcatenationOperatorNode. This is because ConcatenationOperatorNode does
not work off of a ValueNodeList. I have reworded the comments for
getDominantTypeServices() to describe what is doing.
> Set correct collation type and derivation on DataTypeDescriptor(DTD).
> ---------------------------------------------------------------------
>
> Key: DERBY-2599
> URL: https://issues.apache.org/jira/browse/DERBY-2599
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.1.4
> Reporter: Mamta A. Satoor
> Assignee: Mamta A. Satoor
> Fix For: 10.3.1.4
>
> Attachments: DERBY2599_collationType_default_UCS_BASIC_v1_diff.txt,
> DERBY2599_collationType_default_UCS_BASIC_v1_stat.txt,
> DERBY2599_correct_collation_for_cast_v1_diff.txt,
> DERBY2599_correct_collation_for_cast_v1_stat.txt,
> DERBY2599_getNull_should_set_collation_info_v1_diff.txt,
> DERBY2599_getNull_should_set_collation_info_v1_stat.txt,
> DERBY2599_IntermediatePatch_v1_diff.txt,
> DERBY2599_IntermediatePatch_v1_stat.txt,
> DERBY2599_Set_collation_for_aggregates_v1_diff.txt,
> DERBY2599_Set_collation_for_aggregates_v1_stat.txt,
> DERBY2599_Set_collation_for_aggregates_v1_stat.txt,
> DERBY2599_Set_collation_for_Max_Min_v1_diff.txt,
> DERBY2599_set_correct_collation_for_params_and_string_functions_v1_diff.txt,
> DERBY2599_set_correct_collation_for_params_and_string_functions_v1_stat.txt,
> DERBY2599_Use_collation_of_compilation_schema_and_not_current_schema_diff_v1.txt,
>
> DERBY2599_Use_collation_of_compilation_schema_and_not_current_schema_stat_v1.txt
>
>
> DTD has TypeDescriptorImpl in it which has 2 new fields, namely,
> collationType and collationDerivation. These 2 fields are available for all
> different types of DTDs but only apply to character types. The other
> datatypes should ignore these 2 fields.
> This Jira is a placeholder for loading the correct values into collationType
> and collationDerivation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
