[jira] Commented: (DERBY-3050) Convert groupBy.sql tests to JUnit and include them in GroupByTest.java

[Kathey Marsden (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DERBY-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524869
 ] 

Kathey Marsden commented on DERBY-3050:
---------------------------------------

Thanks Bryan for converting these tests.  In using the DERBY-2152 conversion 
tool, can you double check that it does not omit  the fail assert method after 
a method call in a try-catch block when the statement is expected to fail.  
e.g. instead of 

try {
  s.execute(command);
}
catch (SQLException e)
{
   assertSQLState("42502", e);
}
 

It should be:

try {
  s.execute(command);
  fail("Command expected to fail" + command);
}
catch (SQLException e)
{
   assertSQLState("42502", e);
}



> Convert groupBy.sql tests to JUnit and include them in GroupByTest.java
> -----------------------------------------------------------------------
>
>                 Key: DERBY-3050
>                 URL: https://issues.apache.org/jira/browse/DERBY-3050
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.4.0.0
>            Reporter: Bryan Pendleton
>            Assignee: Bryan Pendleton
>            Priority: Minor
>
> There are currently 3 sets of GROUP BY tests:
>  - GroupByExpressionTest.java
>  - GroupByTest.java
>  - groupBy.sql
> The first two tests are JUnit tests; the groupBy.sql tests are old-style 
> harness tests,
> although they are now run in the JUnit framework using the LangScripts 
> technique.
> This sub-task proposes to convert the groupBy.sql tests to JUnit tests, and 
> to include
> them directly into GroupByTest.java.
> The DERBY-2151 conversion tool can be used to assist in the conversion 
> process.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.