[ https://issues.apache.org/jira/browse/DERBY-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-2824: ----------------------------------- Derby Info: [Patch Available] Affects Version/s: 10.4.0.0 Fix Version/s: 10.4.0.0 > Improve error reporting, fix whitespace/formatting issues and replace tabs in > UTF8Reader > ---------------------------------------------------------------------------------------- > > Key: DERBY-2824 > URL: https://issues.apache.org/jira/browse/DERBY-2824 > Project: Derby > Issue Type: Improvement > Components: JDBC > Affects Versions: 10.3.1.4, 10.4.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Minor > Fix For: 10.4.0.0 > > Attachments: derby-2824-1a-tabs_to_spaces.diff, > derby-2824-2a-whitespace_changes.diff, > derby-2824-3a-improved_error_reporting.diff, > derby-2824-3b-improved_error_reporting.diff, derby-2824-4a-javadoc.diff > > > I plan to do the following changes to UTF8Reader: > * Improve the error reporting when hitting a UTF8 decoding error (currently > an UTFDataFormatException with no message). This might also lead to deleting > one helper method for generating an exception (the one with no message). > * Improve error reporting for trying to use the reader after it has been > closed (currently an IOException with no message). > * Remove trailing spaces, and add a few newlines here and there. > * Replace tabs in the file with spaces. > Now, the last point can be discussed, but here are my arguments for doing it: > * The file now has a mix of tabs and spaces (but still more tabs). > * Spaces are the preferred/required method of indentation. > * I want to get it fixed before the branch is cut, which makes it easier to > port fixes from trunk/10.3-NEXT to 10.3. If I don't make it for 10.3, I won't > do it. > * I don't see it as very likely that we will back-port major fixes to this > class on the 10.2 branch. If we have to, I will volunteer :) > * Since so much else of the Clob "infrastructure" has changed recently, this > seems like a good time to do the clean-up. > Please raise your concern as soon as possible if you want to veto these > changes. > I do plan to commit them tomorrow. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.