[
https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-3149:
-----------------------------------
Attachment: derby-3149-2a-conditional_compilation_fix.diff
Dag H. Wanvik commented on derby-dev:
"The patch seems to compile some files every time, even if already
compiled. Is that intentional?"
No this was not intentional.
I had a look at it, and it turned out I had specified the wrong path for the
srcdir attribute in the javac ant target. Ant expects the srcdir and destdir
hierarchies to be the same. These properties are used to determine which files
have to be compiled based on their timestamps.
Second, I decided to tell javac to compile all *java files in the tree, even
though it could have been enough with just compiling the top-level file
(PackagePrivateTestSuite). However, when this is done only the timestamp of
that single file is checked, and the target would not recompile other changed
files as long as PackagePrivateTestSuite remained unchanged.
I have uploaded 'derby-3149-2a-conditional_compilation_fix.diff' to fix these
issues, and also chose to always compile with debug=true, added some comments
and removed all references to 'derby.pptesting.src.dir'.
Note that the compilation classpath still have to be fixed/replaced before the
issue is closed.
Dag, thanks for testing the patch :)
> Add ant targets for building and running the package private tests against
> the classes directories
> --------------------------------------------------------------------------------------------------
>
> Key: DERBY-3149
> URL: https://issues.apache.org/jira/browse/DERBY-3149
> Project: Derby
> Issue Type: Sub-task
> Components: Build tools, Test
> Affects Versions: 10.4.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: derby-3149-1a.diff, derby-3149-1a.stat,
> derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories.
> Implementing a solution that runs against jars is not technically difficult,
> it just brings a host of decisions to be taken... Maybe even more important,
> does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation.
> Feel free to post your concerns if you think building the package private
> tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
