[ https://issues.apache.org/jira/browse/DERBY-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550401 ]
Thomas Nielsen commented on DERBY-2998: --------------------------------------- An email discussion with A B on derby-dev indicates that the conditional pushing I originally did in PredicateList was correct after all :) So I need to sort out how I can get the failing join Knut reported to work, and also why the less than works, but greater than doesn't. I started looking at triggerig materializing the OLAPResultSet by returning true from OLAPNode.performMaterialization() as one option. I might need to move the generation of calls to increment code from ResultColumnList.generateCore() and down into RowNumberColumnNode.generateCore(). I'm also wondering wether the call shouldn't be made into BaseActivation like in d2998-6.diff. I'll keep digging... > Add support for ROW_NUMBER() window function > -------------------------------------------- > > Key: DERBY-2998 > URL: https://issues.apache.org/jira/browse/DERBY-2998 > Project: Derby > Issue Type: Sub-task > Components: SQL > Reporter: Thomas Nielsen > Assignee: Thomas Nielsen > Priority: Minor > Attachments: d2998-4.diff, d2998-4.stat, d2998-5.diff, d2998-5.stat, > d2998-6.diff, d2998-6.stat, d2998-test.diff, d2998-test.stat, > d2998-test2.diff, d2998-test2.stat > > > As part of implementing the overall OLAP Operations features of SQL > (DERBY-581), implement the ROW_NUMBER() window function. > More information about this feature is available at > http://wiki.apache.org/db-derby/OLAPRowNumber -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.