[ https://issues.apache.org/jira/browse/DERBY-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551221 ]
Mamta A. Satoor commented on DERBY-3037: ---------------------------------------- I addressed the item 1 above and fixed the failure in outjoin.sql with revision 603823 in trunk. The commit comments were as follows DERBY-3261 and part of DERBY-3037 The outerjoin.sql was failing because the part of the runtime statistcis info was getting erased before LanguageResultSet.close() code collected it all. I moved the erasing of runtime stat code so that it happened once the stat was collected successfully. In addition, I removed redundant code of closing and finishing the LanguageResultSet from EmbedResultSet.java because these steps happen as part of activation.close I will merge this into 10.3 codeline and fire the tests there. > Language ResultSet.finish() is called even when the ResultSet is going to be > re-used. > ------------------------------------------------------------------------------------- > > Key: DERBY-3037 > URL: https://issues.apache.org/jira/browse/DERBY-3037 > Project: Derby > Issue Type: Bug > Components: SQL > Affects Versions: 10.4.0.0 > Reporter: Daniel John Debrunner > Assignee: Mamta A. Satoor > Fix For: 10.3.2.2, 10.4.0.0 > > > DERBY-827 (correctly) changed the lifetime of the language ResultSet tree to > be the lifetime of the activation, but did not fix up the correct calls to > ResultSet.close() and ResultSet.finish(). > A language ResultSet's lifetime should be driven by the activation, so > activation.close() should call finish() on its ResultSet. > EmbedResultSet should call close on its language ResultSet (theResults field) > when the JDBC ResultSet is closed, it should not be calling finish() on its > ResultSet. > See comments in DERBY-827 for some more details and issues. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.