[ https://issues.apache.org/jira/browse/DERBY-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555572#action_12555572 ]
John H. Embretsen commented on DERBY-3294: ------------------------------------------ Thanks for the update. Some follow-up comments, having considered the second patch: - I think it may be possible to implement the doDelete(), doUpdate() and doSelect() methods as independent fixtures (by utilizing rollback(), setUp()/tearDown() and possibly a new test setup class) or to specify a specific ordering of fixtures in the suite() method, but the current scheme works quite well, so keeping it is ok with me. - I think it is confusing to have both the methods insertMaps() and InsertMaps(). One suggestion is to comply with common Java naming conventions and use a lowercase letter in the beginning of method names, for example by renaming InsertMaps() to insertMapsPrivileged(). - the non-JUnit version of this test tests that select count(*) works (not sure of the intended purpose of doing this) from all the tables both before and after deletes/updates, while the new version only selects before doUpdate()/doDelete(). Is that intentional? (I'm not saying it should be different, I just think the reasoning behind this decision should be on record.) - testToursDB() method's Javadoc specifies a wrong exception in the @throws tag. There is also a typo (tourdb --> ToursDB) in the Javadoc. - tearDown() lacks @throws tag in Javadoc. > Convert demo/checkToursDB.java to junit > --------------------------------------- > > Key: DERBY-3294 > URL: https://issues.apache.org/jira/browse/DERBY-3294 > Project: Derby > Issue Type: Test > Components: Test > Affects Versions: 10.4.0.0 > Reporter: Manjula Kutty > Assignee: Manjula Kutty > Priority: Minor > Fix For: 10.4.0.0 > > Attachments: DERBY-3294_diff_12_28.txt, DERBY-3294_stat_12_28.txt, > DERBY_3294_diff_01_02.txt, DERBY_3294_stat_01_02.txt > > > Place holder for the junit conversion of demo/checkToursDB.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.