[ 
https://issues.apache.org/jira/browse/DERBY-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556746#action_12556746
 ] 

Kristian Waagan commented on DERBY-3149:
----------------------------------------

Kathey,

I do not mind the change you have proposed, I just want to make clear that what 
the target really needs is to compile against the Java SE 5.0 libraries. There 
is no need for JDK 1.6, but as far as I know there is no 
java15compile.classpath, and compile.classpath is set to J2SE 1.4.2.

+1 to commit, unless someone knows how to get Java SE 5.0 libraries. If 
committed, I assume the target will revert back to Java SE 5.0 when the 
"infrastructure" is in place.

> Add ant targets for building and running the package private tests against 
> the classes directories
> --------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3149
>                 URL: https://issues.apache.org/jira/browse/DERBY-3149
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Build tools, Test
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3149-1a.diff, derby-3149-1a.stat, 
> derby-3149-1b.diff, derby-3149-2a-conditional_compilation_fix.diff, 
> derby-3149-2b-conditional_compilation_fix.diff, 
> pptesting_use_jdk16_executable_diff.txt
>
>
> Create ant targets in build.xml to compile and run the package private tests.
> The first step will be to run the tests against the classes directories. 
> Implementing a solution that runs against jars is not technically difficult, 
> it just brings a host of decisions to be taken... Maybe even more important, 
> does running against the jars add any value?
> The compile will be included in the 'all' target to test the implementation. 
> Feel free to post your concerns if you think building the package private 
> tests should be a manual action only.
> The tests will also be run as part of junit-all / junitreport.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to