[ 
https://issues.apache.org/jira/browse/DERBY-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564117#action_12564117
 ] 

Daniel John Debrunner commented on DERBY-3213:
----------------------------------------------

Did you run any tests with this patch? Derby generates Java byte code to 
execute SQL statements and therefore the only path to some methods is through 
the generated code. Thus Derby might build successfully but fail at runtime.

> SQLChar.trim method is unused and could be removed
> --------------------------------------------------
>
>                 Key: DERBY-3213
>                 URL: https://issues.apache.org/jira/browse/DERBY-3213
>             Project: Derby
>          Issue Type: Improvement
>          Components: Newcomer, SQL
>            Reporter: Bryan Pendleton
>            Assignee: Deepthi Devaki A R
>            Priority: Minor
>         Attachments: DERBY-3213.diff
>
>
> As part of researching DERBY-2352, I came to the conclusion that
> the trim() method in SQLChar.java is no longer used, and could be
> removed. It appears that all calls to this method have been switched
> to call ansiTrim() instead.
> Hopefully, this just requires removing the code from SQLChar.java
> and StringDataValue.java, and running all the tests to verify that
> nothing is broken.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to