[
https://issues.apache.org/jira/browse/DERBY-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564352#action_12564352
]
Kristian Waagan commented on DERBY-1400:
----------------------------------------
Thanks for providing the patch, Abhilash.
I had a quick look at it, and it seems to me it is a lot bigger than it has to
be because of unrelated whitespace changes.
There is a preference in the Derby community to leave unrelated whitespace
changes out of patches fixing other issues. I do notice that the class you are
working on (DRDAStatement) contains a mix of tabs and spaces, and also a number
of lines with trailing whitespace.
The current policy for new Derby source code is to use four spaces for
indentation.
1) Can you please make another patch, where you don't incorporate unrelated
whitespace changes?
2) Have you run any regression tests for the changes?
If you have questions, feel free to ask!
thanks,
> Cleanup code in network server's DRDAStatement class
> ----------------------------------------------------
>
> Key: DERBY-1400
> URL: https://issues.apache.org/jira/browse/DERBY-1400
> Project: Derby
> Issue Type: Improvement
> Components: Network Server, Newcomer
> Affects Versions: 10.1.3.1, 10.2.1.6
> Reporter: Deepa Remesh
> Assignee: Abhilash T.G
> Priority: Trivial
> Attachments: DERBY-1400.diff
>
>
> The following cleanup tasks were identified as part of DERBY-1002
> (http://issues.apache.org/jira/browse/DERBY-1002):
> * pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since
> these are derived from pkgnamcsn object.
> * Look into what is required by initialize() of default statement. Currently,
> initialize just calls setTypDefValues(). Once the purpose of this method is
> confirmed, we may need to modify the comments at places it is currently
> called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
