[ 
https://issues.apache.org/jira/browse/DERBY-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565305#action_12565305
 ] 

Kristian Waagan commented on DERBY-3325:
----------------------------------------

Kristian wrote:
-----
I logged DERBY-3306 a while ago for the bug in the framework regarding data 
sources, but it is for a specific test and not for the general problem. I do 
plan to use another mechanism in my tests (a decorator, see DERBY-3326), and 
the problem will go away.
-----

I just realized what I wrote above is a lie. I won't be able to control the 
data source / connection to the degree I want to by using the decorator, so I 
still have to use the old mechanism which has the bug.

>From a very quick look at the issue, I think the easiest solution would be to 
>set the create database property on the data source by default. This because 
>the data source object reference is given out to the requester, and the 
>getConnection call is executed in/by the requesters code and the framework 
>can't catch the database-not-found-exception and retry with create=true.

The above solution seems better to me than for instance trying to obtain a 
connection before the data source reference is published (and create the 
database if it does not exist), as it gives the requester the possibility to 
force create=false if that is what the test requires.

Have I overlooked any simpler / better solutions?

> Add 'maxStatements' property to ClientConnectionPoolDataSource
> --------------------------------------------------------------
>
>                 Key: DERBY-3325
>                 URL: https://issues.apache.org/jira/browse/DERBY-3325
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>         Attachments: DataSourceReferenceTest.diff, 
> DataSourceReferenceTest.java, derby-3325-1a-maxStatements.diff, 
> derby-3325-1a-maxStatements.stat
>
>
> The classes in Derby implementing javax.sql.ConnectionPoolDataSource must 
> provide setter and getter methods for the property 'maxStatements'.
> This property is used to control the whether the data source should produce 
> pooled connections with statement cache capabilities or not, and how big the 
> statement cache is allowed to be.
> This issue only deals with the client JDBC driver.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to