[ 
https://issues.apache.org/jira/browse/DERBY-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571629#action_12571629
 ] 

Daniel John Debrunner commented on DERBY-3310:
----------------------------------------------

ResultSetNode.genNormalizeResultSetNode() is a little strange:

Its purpose is to push a normalize result set node on-top of a ResultSetNode.

The passed in child node is always the node is actually invoked on, so it's 
always operating on this.
(I'll attach a simple patch for that, it simplifies the code a little, 
otherwise it appears the method is operating on
two result set nodes instead of just itself.

What's strange to me is that even though it is wrapping itself with a normalize 
node, the code ends up modifying
its own resultColumns. A normal, expected pattern for such a situation is that 
the node to be wrapped would
be unmodified by pushing a normalize node on top of it. This could be related 
to this issue, the source nodes and
target nodes might be being mixed up.

[sorry if this appears unclear, it's just something I noticed and wanted to 
quickly throw out there]

> ASSERT in MergeSort.checkColumnTypes() disallow legal type conversions
> ----------------------------------------------------------------------
>
>                 Key: DERBY-3310
>                 URL: https://issues.apache.org/jira/browse/DERBY-3310
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.4.0.0
>            Reporter: Dyre Tjeldvoll
>            Assignee: Kathey Marsden
>            Priority: Minor
>         Attachments: cast-repro.sql, derby-3310_try1_diff.txt
>
>
> The following code 
> CREATE TABLE U (SNAME VARCHAR(32000), TNAME VARCHAR(32000), C1 BIGINT);
> -- This triggers an ASSERT (because 2 is INTEGER and not BIGINT)
> INSERT INTO U(SNAME, TNAME, C1) SELECT DISTINCT SCHEMANAME, TABLENAME, 2
>  FROM SYS.SYSTABLES T JOIN SYS.SYSSCHEMAS S ON T.SCHEMAID = S.SCHEMAID;
> gives
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class 
> org.apache.derby.iapi.types.SQLInteger) expected to be the same as 
> col2.getClass() (class org.apache.derby.iapi.types.SQLLongint): 
> org.apache.derby.shared.common.sanity.AssertFailure'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to