[ 
https://issues.apache.org/jira/browse/DERBY-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571934#action_12571934
 ] 

Daniel John Debrunner commented on DERBY-1387:
----------------------------------------------

Nice update on the spec:

 - as a general comment I think the spec should focus on the general jmx setup 
rather than specific MBeans, attributes, operations etc. Maybe just add a 
sentence indicating the MBeans listed are valid when the spec is written but 
may be subject to change. E.g. if a new attribute is added to VersionMBean then 
having to update the spec seems over the top.

  - For VersionMBean I think the getBuildNumberAsInt should be removed, the 
build number may not be an integer so not providing a conversion method may 
reinforce that fact. It also adds little value.

 - In the security section it says "When using a custom policy file, the 
following additional permissions must be granted to derby.jar ". That's not 
true, Derby could provide monitoring with a sub-set of those permissions. Not 
sure what should be put here, maybe just a description of why each permission 
is required.
  IN the same section PropertyPermission should be removed, it's not required 
for JMX at the moment and may never be.

 - In the MBeanServer section it says:
  "When Derby's Management Service has been started, a valid JMX user will be 
able to access both the Derby-specific MBeans registered by the Management 
Service, as well as any other MBeans or MXBeans made available by the managed 
JVM, if the JMX client supports this."
  It's more complicated than that, given the definition of JMX user, it's not 
true that such a JMX user "will be able to access both ...", a JMX User may be 
restricted into which MBeans it can access or even see.

> Add JMX extensions to Derby
> ---------------------------
>
>                 Key: DERBY-1387
>                 URL: https://issues.apache.org/jira/browse/DERBY-1387
>             Project: Derby
>          Issue Type: New Feature
>          Components: JMX
>            Reporter: Sanket Sharma
>            Assignee: John H. Embretsen
>         Attachments: DERBY-1387-1.diff, DERBY-1387-1.stat, DERBY-1387-2.diff, 
> DERBY-1387-2.stat, DERBY-1387-3.diff, DERBY-1387-3.stat, DERBY-1387-4.diff, 
> DERBY-1387-4.stat, DERBY-1387-5.diff, DERBY-1387-5.stat, DERBY-1387-6.zip, 
> DERBY-1387-7.zip, DERBY-1387-8.zip, DERBY-1387-9.diff, DERBY-1387-9.stat, 
> derby1387_simple_9_1.txt, derbyjmx.patch, jmx.diff, jmx.stat, 
> jmxFuncspec.html, jmxFuncspec.html, jmxFuncspec.html, jmxFuncspec.html, 
> jmxPolicyFileChanges_v1.diff, Requirements for JMX Updated.html, Requirements 
> for JMX.html, Requirements for JMX.zip
>
>
> This is a draft requirement specification for adding monitoring and 
> management extensions to Apache Derby using JMX. The requirements document 
> has been uploaded on JIRA as well as the Derby Wiki page at 
> http://wiki.apache.org/db-derby/_Requirement_Specifications_for_Monitoring_%26_Management_Extensions_using_JMX
> Developers and Users are requested to please look at the document (feature 
> list in particular) and add their own rating to features by adding a coloumn 
> to the table.
> Comments are welcome.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to