[ https://issues.apache.org/jira/browse/DERBY-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573638#action_12573638 ]
Øystein Grøvlen commented on DERBY-3162: ---------------------------------------- I tried to run the ReplicationRun_Local test, but in order for it to run, I had to manually create the directories db_master and db_slave for the test to run. Since this patch does not affect people not working on replication, I suggest that I commit the patch more or less as it is, and then we can do I more thorough review afterwards. Some initial comments based on a quick look at parts of the patch: - I assume you did not intend to include the build.xml.orig file. - Do you intend to document ReplicationRun_Local in README.runningTests? - I did not understand the following line in README.runningTests: cd <testing dir>/ # ${user.dir} - README.framework seems a bit out of date - Some general observations: - Several classes has a lot of unused imports. - Many very long lines - For some classes I miss an initial javadoc that explains the purpose of the class. - As far as I know, there should be only one exception per @throws tag. > Create a framework for replication tests > ---------------------------------------- > > Key: DERBY-3162 > URL: https://issues.apache.org/jira/browse/DERBY-3162 > Project: Derby > Issue Type: Sub-task > Components: Test > Affects Versions: 10.4.0.0 > Reporter: Ole Solberg > Assignee: Ole Solberg > Priority: Minor > Attachments: derby-3162.1-v1.diff.txt, derby-3162.2-v2.diff.txt, > derby-3162.2-v2.stat.txt > > > Handle > - starting and stopping Derby servers to have the master and slave > replication roles, > - doing administrative commands like startreplication, startslave, > stopreplication, failover, > - performing consistency checks on the slave vs. the master, > - running load clients against master and slave in the various states of > replication, > - provoking error situations on master and slave, and network, > - ... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.