[ https://issues.apache.org/jira/browse/DERBY-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576724#action_12576724 ]
Knut Anders Hatlen commented on DERBY-3503: ------------------------------------------- The patch basically looks good. Some minor comments: - ThreadDump.java lacks ASL header - The changes to the signatures of main() and execTesters() seem to be pure white-space changes (changing tabs to mix of tabs/spaces) - The changes to main()'s javadoc look unintended (changes tabs to spaces, and incorrectly changes FileNotFoundException to ParseException) - The indentation for the new code in execTesters() seems to be off. Have you checked that your IDE has tab stop set to 4? - This code could be written as "if (j.atLeast(1, 5))" instead: + if (j.getMajorNumber() == 1 && j.getMinorNumber() >= 5 || + j.getMajorNumber() > 1) - ThreadDump.java is a bit hard to read since it's not properly indented - The patch adds some lines with trailing spaces > Change stress.multi to dump thread stacks before killing off testers with jdk > 1.5 and higher > -------------------------------------------------------------------------------------------- > > Key: DERBY-3503 > URL: https://issues.apache.org/jira/browse/DERBY-3503 > Project: Derby > Issue Type: Improvement > Components: Test > Affects Versions: 10.4.0.0 > Reporter: Kathey Marsden > Assignee: Kathey Marsden > Priority: Minor > Attachments: derby-3503_diff.txt > > > Jdk 1.5 introduced Thread.getAllStackTraces() which can be used to print a > thread dump programatically. The test stress.multi kills off its testers if > it reaches a deadlock or the testers can't complete on their own. It would be > helpful in this case to get a thread dump automatically. The code could only > be enabled for jdk 1.5 and higher. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.