[
https://issues.apache.org/jira/browse/DERBY-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-3379:
-----------------------------------
Attachment: derby-3379-2a-comment_and_JavaDoc.diff
'derby-3379-2a-comment_and_JavaDoc.diff' cleans up some comments in buildDss.
One of the comments confused me at first, because it said chaining bits were
always set, followed by two 0xFF assignments in the byte array. Turned out this
was the length bytes, and that the chaining bits are not unconditionally set
(as part of this method).
It also converts comments for method finalizeDssLength into JavaDoc.
I committed 2a to trunk with revision 637805.
I plan to merge all commits for this issue to the 10.4 branch when the issue
has been resolved.
My further work here looks like this:
* Address Knut's comments and upload a new "base patch".
* Upload two enabling patches, one broad (current) and one isolated fix.
I will spend a little more time looking into the issue and see if the fix can
be made smaller. If not, I hope the isolated fix can go in. The plan is to only
change the chaining flag if there are no result sets to close, as opposed to
checking and possibly resetting the chaining flag on every flush (broad
approach).
My opinion is that even if the isolated fix may not be perfect, it should go
in. We have users seeing the problem, and the patch fixes it without breaking
any of the regression tests.
If others want to pursue a different fix, they are welcome to do so :)
(but please let me know so we don't duplicate our efforts)
I do plan to get this in for the 10.4 release.
> "No Current connection" on PooledConnection.getConnection() if pooled
> connection is reused during connectionClosed processing
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3379
> URL: https://issues.apache.org/jira/browse/DERBY-3379
> Project: Derby
> Issue Type: Bug
> Components: Network Client
> Affects Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.1.2.1, 10.1.3.1,
> 10.2.1.6, 10.2.2.0, 10.3.1.4, 10.3.2.1
> Reporter: Kathey Marsden
> Assignee: Kristian Waagan
> Attachments: derby-3379-1a-enforce_no_chaining.diff,
> derby-3379-1a-enforce_no_chaining.diff,
> derby-3379-1a-enforce_no_chaining.stat,
> derby-3379-1a-enforce_no_chaining.stat,
> derby-3379-1b-enforce_no_chaining.diff,
> derby-3379-1c-enforce_no_chaining.diff,
> derby-3379-1c-enforce_no_chaining.stat, derby-3379-2a-comment_and_JavaDoc.diff
>
>
> This is the client version of bug DERBY-2142. It can be reproduced by
> enabling the test, DataSourceTest.testPooledReuseOnClose() for client. I am
> opening a new issue for client as the embedded fix was backported to 10.1 and
> I am guessing the client fix won't be backported that far. Better to keep it
> as a separate issue.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
