[ 
https://issues.apache.org/jira/browse/DERBY-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599410#action_12599410
 ] 

Dag H. Wanvik commented on DERBY-3682:
--------------------------------------

Changes look good to me. Nice that we now have a well defined place for the 
quoting/unquoting code!
I guess the JDBC#escape code could/should be generalized to work for strings as 
well as identifiers.

+1

> SYSCS_BULK_INSERT doesn't quote identifiers or strings properly
> ---------------------------------------------------------------
>
>                 Key: DERBY-3682
>                 URL: https://issues.apache.org/jira/browse/DERBY-3682
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.4.1.3
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d3682.diff, d3682a.diff
>
>
> Discovered by Mamta A. Satoor in DERBY-1062.
> SYSCS_BULK_INSERT builds an insert statement in which it doesn't quote the 
> schema name or the table name. It also takes string parameters that are 
> inserted into the statement text with single quotes around them, but that 
> won't work if those strings contain single quote characters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to