[ 
https://issues.apache.org/jira/browse/DERBY-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kristian Waagan updated DERBY-3768:
-----------------------------------

    Attachment: derby-3768-1b-length_skip.diff

Committed revision 1b of the patch, in which the only change over 1a is the 
addition of an else-block, to trunk with revision 675169.

Thanks for the review Dag. 
I agree the InputStream.skip contract is somewhat difficult. We already have a 
utility class for UTF8 streams (iapi.util.UTF8Util), so adding one for generic 
InputStreams is a good idea.
I created DERBY-3770 for this task.

> Make EmbedBlob.length use skip instead of read
> ----------------------------------------------
>
>                 Key: DERBY-3768
>                 URL: https://issues.apache.org/jira/browse/DERBY-3768
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 10.5.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: derby-3768-1a-length_skip.diff, 
> derby-3768-1b-length_skip.diff
>
>
> EmbedBlob.length uses read to process the whole Blob when the length has not 
> been encoded at the head of the stream.
> Using skip instead of read can lead to better performance.
> I also plan to make some minor cleanups under this issue; JavaDoc and to 
> rename a variable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to