[
https://issues.apache.org/jira/browse/DERBY-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629748#action_12629748
]
Knut Anders Hatlen commented on DERBY-3063:
-------------------------------------------
The patch looks good to me. I don't have the Open Group CLI specification
(which defines the semantics for the scalar escape functions, according to the
JDBC spec) to check, so I'll just assume that StrictMath.atan2() has the
expected semantics. No tests were added in the patch, but I verified that
DatabaseMetaDataTest failed when I removed the row for ATAN2 in the
SYSFUN_FUNCTIONS array (there's some kind of automatic testing that calls
getNumericFunctions() and checks that the actual behaviour and the meta-data
match).
+1 to commit.
> Extend the system function mechanism to support functions with multiple
> arguments
> ---------------------------------------------------------------------------------
>
> Key: DERBY-3063
> URL: https://issues.apache.org/jira/browse/DERBY-3063
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 10.4.1.3
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Attachments: derby-3063-1a-preview.diff, derby-3063-1a-preview.stat,
> derby-3063-2a.diff
>
>
> Extend the existing functionality for adding Java functions to SQL to support
> functions with multiple arguments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
