[
https://issues.apache.org/jira/browse/DERBY-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633408#action_12633408
]
Kim Haase commented on DERBY-3874:
----------------------------------
I can document this, but I have a few questions.
1) The javadoc for atan reports only a couple of odd cases, for values of NaN
or zero. The Ref Manual documentation for atan has similar odd cases, for NULL
and zero. The javadoc for atan2, on the other hand, has a whole lot of odd
cases for various values of the two arguments. Should they all be mentioned,
and should it be obvious how these translate? (I have documented floating-point
functions before so I'm not entirely at sea here ...)
2) I notice that the file
java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java
has exactly one atan2 test, for a normal set of values. This file also has
just one test for atan. However, the file
java/testing/org/apache/derbyTesting/functionTests/tests/lang/MathTrigFunctionsTest.java
has some reasonably extensive testing for atan, but none at all for atan2.
Does it make sense to document this function when it isn't thoroughly tested
yet?
> Document numeric function ATAN2(float1,float2)
> ----------------------------------------------
>
> Key: DERBY-3874
> URL: https://issues.apache.org/jira/browse/DERBY-3874
> Project: Derby
> Issue Type: Sub-task
> Components: Documentation
> Affects Versions: 10.5.0.0
> Reporter: Kristian Waagan
>
> Document the numeric function ATAN2(float1,float2).
> Mentioned in the JDBC specification, appendix C.1.
> Implementation documented by the JavaDoc for StrictMath.atan2.
> According to the JDBC specification, table B-1, a JDBC float maps to a Java
> double.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
