[ https://issues.apache.org/jira/browse/DERBY-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645763#action_12645763 ]
Knut Anders Hatlen commented on DERBY-3936: ------------------------------------------- I agree that the builder pattern is cleaner than having many constructors and/or a constructor with a dozen parameters when immutability is a goal. But doesn't Builder's two-arg constructor break the pattern? Isn't it clearer to have methods for those two fields as well? > Add CharacterStreamDescriptor > ----------------------------- > > Key: DERBY-3936 > URL: https://issues.apache.org/jira/browse/DERBY-3936 > Project: Derby > Issue Type: Sub-task > Components: JDBC > Affects Versions: 10.5.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Minor > Attachments: derby-3936-1a-CharacterStreamDescriptor.diff > > > A set of state information is required about byte streams representing > characters to be able to handle them properly. > The basic pieces of information are: > - is bufferable > - is position aware > - data offset > - current byte position > - current char position > - byte length > - char length > Additional info: > - encoding > - max allowed length > - bytes per char information > The information is chosen with UTF8Reader in mind, and the plan is to pass a > CharacterStreamDescriptor instance to the constructor to allow the reader to > configure itself appropriately. The information is expected to be valid only > at a specific point in time, as some of it will change as soon as the reader > starts working with the underlying stream. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.