[
https://issues.apache.org/jira/browse/DERBY-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-3907:
-----------------------------------
Attachment: derby-3907-5a-use_getStreamWithDescriptor.diff
derby-3907-5a-use_getStreamWithDescriptor.stat
Patch 'derby-3907-5a-use_getStreamWithDescriptor.diff' takes the new
StringDataValue.getStreamWithDescriptor() into use.
Description of changes:
o EmbedClob
Changed constructor to take a StringDataValue instead of a
DataValueDescriptor.
Updated call to the StoreStreamClob constructor.
o EmbedResultSet
Started using the getStreamWithDescriptor method and updated invocations of
the UTF8Reader constructor.
o StoreStreamClob
Added a CharacterStreamDescriptor, and made the constructor take one as an
argument.
Adapted the class to use a CSD.
o UTF8Reader
Updated some comments.
Fixed bug where the header length wasn't added to the byte length of the
stream, and updated the class appropriately (adjusted utfCount, fixed the reset
routine).
Made sure the header bytes are skipped (either by skipping them in the
constructor or by adjusting the position to on the next reposition).
o ResultSetStreamTest
Added a test for maxFieldSize, where truncation have to happen.
o Various tests
Adjusted tests to run with the new implementation.
Patch ready for review.
Regression tests ran cleanly, but due to a last minute change I have to rerun
them again. I will post the results tomorrow.
> Save useful length information for Clobs in store
> -------------------------------------------------
>
> Key: DERBY-3907
> URL: https://issues.apache.org/jira/browse/DERBY-3907
> Project: Derby
> Issue Type: Improvement
> Components: JDBC, Store
> Affects Versions: 10.5.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Fix For: 10.5.0.0
>
> Attachments: derby-3907-1a-alternative_approach.diff,
> derby-3907-2b-header_write_preparation.diff,
> derby-3907-2b-header_write_preparation.diff,
> derby-3907-2b-header_write_preparation.stat,
> derby-3907-2c-header_write_preparation-PREVIEW.diff,
> derby-3907-2c-header_write_preparation-PREVIEW.stat,
> derby-3907-2c-header_write_preparation.diff,
> derby-3907-2c-header_write_preparation.diff,
> derby-3907-2c-header_write_preparation.stat,
> derby-3907-3a-readertoutf8stream_cleanup.diff,
> derby-3907-3a-readertoutf8stream_cleanup.diff,
> derby-3907-3a-readertoutf8stream_cleanup.stat,
> derby-3907-3b-readertoutf8stream_cleanup.diff,
> derby-3907-4a-add_getStreamWithDescriptor.diff,
> derby-3907-4a-add_getStreamWithDescriptor.stat,
> derby-3907-5a-use_getStreamWithDescriptor.diff,
> derby-3907-5a-use_getStreamWithDescriptor.stat
>
>
> The store should save useful length information for Clobs. This allows the
> length to be found without decoding the whole data stream.
> The following thread raised the issue on what information to store, and also
> contains some background information:
> http://www.nabble.com/Storing-length-information-for-CLOB-on-disk-tp19197535p19197535.html
> The information to store, and the exact format of it, is still to be
> discussed/determined.
> Currently two bytes are set aside for length information, which is inadequate.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
