[
https://issues.apache.org/jira/browse/DERBY-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693937#action_12693937
]
Kathey Marsden edited comment on DERBY-3842 at 3/30/09 4:18 PM:
----------------------------------------------------------------
The patch looks good to me except I am not sure the if (SanityManager.DEBUG)
in store._Suite is going to work with an insane build, because the
SanityManager class is not present at all.
I think you will have to use reflection to determine if this is a sane build
and perhaps the best thing to do is put an isSane() method in
TestConfiguration so it can be used by others if needed in the future.
Then I don't know if it would be worthwhile to keep the test running for insane
builds and then just put the isSane() condition around the
RuntimeStatisticsParser call or if the test is just of no use in insane mode.
was (Author: kmarsden):
The patch looks good to me except I am not sure the if
(SanityManager.DEBUG) in store._Suite is going to work with an insane build,
because the SanityManager class is not present at all.
I think you will have to use reflection to determine if this is a sane build
and perhaps the best thing to do is put an isSane() method in
TestConfiguration so it can be used by others if needed in the future.
Then I don't know if it would be worthwhile to keep the test running for insane
builds and then just put the isSane() condition around the
RuntimeStatisticsParser call or if the test is just of no use in sane mode.
> Convert
> "org.apache.derbyTesting.functionTests.tests.store.holdCursorExternalSortJDBC30.sql"
> to junit.
> ------------------------------------------------------------------------------------------------------
>
> Key: DERBY-3842
> URL: https://issues.apache.org/jira/browse/DERBY-3842
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Junjie Peng
> Assignee: Tiago R. Espinha
> Attachments: derby-3842-1.patch, derby-3842-1.stat,
> derby-3842-tiago.patch, derby-3842-tiago.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
