[
https://issues.apache.org/jira/browse/DERBY-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694043#action_12694043
]
Kristian Waagan commented on DERBY-4119:
----------------------------------------
My only comment to catching OOME instead of guessing the largest supported
array size, is that for JVMs that don't support arrays of size
Integer.MAX_VALUE you may end up with a lot smaller array, right?
Again, I haven't checked the code, but I assume this will lead to more stages
in the sort, and not failing to do the sort itself?
If so, the approach sounds good to me.
Another nit is to add a comment where you catch the OOME, stating it was done
to resolve the issue that some (older?) JVMs don't support arrays of size
Integer.MAX_VALUE (or just point to DERBY-4119).
Code catching OOME tends to raise suspicion :)
> Compress on a large table fails with IllegalArgumentException - Illegal
> Capacity
> --------------------------------------------------------------------------------
>
> Key: DERBY-4119
> URL: https://issues.apache.org/jira/browse/DERBY-4119
> Project: Derby
> Issue Type: Bug
> Components: Store
> Affects Versions: 10.5.1.0
> Reporter: Kristian Waagan
> Assignee: Knut Anders Hatlen
> Attachments: overflow.diff, overflow2.diff, overflow3.diff
>
>
> When compressing a large table, Derby failed with the following exception:
> IllegalArgumentException; Illegal Capacity: -X
> I was able to access the database afterwards, but haven't yet checked if all
> the data is still available.
> The compress was started with CALL SYSCS_UTIL.SYSCS_COMPRESS_TABLE('schema',
> 'table', 1) from ij.
> The data in the table was inserted with 25 concurrent threads. This seems to
> cause excessive table growth, as the data inserted should weigh in at around
> 2 GB. The table size after the insert is ten times bigger, 20 GB.
> I have been able to generate the table and do a compress earlier, but then I
> have been using fewer insert threads.
> I have also been able to successfully compress the table when retrying after
> the failure occurred (shut down the database, then booted again and
> compressed).
> I'm trying to reproduce, and will post more information (like the stack
> trace) later.
> So far my attempts at reproducing has failed. Normally the data is generated
> and the compress is started without shutting down the database. My attempts
> this far has consisted of doing compress on the existing database (where the
> failure was first seen).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
