[
https://issues.apache.org/jira/browse/DERBY-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719436#action_12719436
]
Knut Anders Hatlen commented on DERBY-4246:
-------------------------------------------
This looks like a useful refactoring/cleanup. +1
While you're at it, I noticed this diff in the patch (not code added by you,
just restructured):
+ } catch (SQLException se) {
+ int ec = se.getErrorCode();
+ String ss = se.getSQLState();
+ String msg = ec + " " + ss + " " + se.getMessage();
+ util.DEBUG("4. Unexpectedly failed to connect: " +
+ connectionURL + " " + msg);
+ assertTrue("Unexpectedly failed to connect: " +
+ connectionURL + " " + msg, false);
Couldn't this catch block be removed? That would simplify the code even more
and also preserve the stack trace of the unexpected exception.
> '.replicationTests.ReplicationRun_Local_3_p5).testReplication_Local_3_p5_DERBY_3878()'
> fails w/ "Could not perform operation 'stopSlave' because the database '...'
> has not been booted".
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-4246
> URL: https://issues.apache.org/jira/browse/DERBY-4246
> Project: Derby
> Issue Type: Bug
> Components: Replication, Test
> Affects Versions: 10.6.0.0
> Environment: OS:
> Microsoft© Windows VistaT Ultimate - 6.0.6001 Service Pack 1 - WindowsNT 0 6
> Microsoft(R) Windows(R) Server 2003, - 5.2.3790 Service Pack 2 - WindowsNT 2 5
> Microsoft Windows XP Professional - 5.1.2600 Service Pack 3 Build 2600 -
> CYGWIN_NT-5.1 1.5.25(0.156/4/2) 2008-06-12 19:34 Cygwin
> JVM:
> Sun Microsystems Inc. java version "1.6.0_06" Java(TM) SE Runtime Environment
> (build 1.6.0_06-b02) Java HotSpot(TM) Client VM (build 10.0-b22 mixed mode
> 32-bit)
> Sun Microsystems Inc. java version "1.5.0_14" Java(TM) 2 Runtime Environment,
> Standard Edition (build 1.5.0_14-b03) Java HotSpot(TM) Client VM (build
> 1.5.0_14-b03 mixed mode 32-bit)
> Sun Microsystems Inc. java version "1.4.2_13" Java(TM) 2 Runtime Environment,
> Standard Edition (build 1.4.2_13-b06) Java HotSpot(TM) Client VM (build
> 1.4.2_13-b06 mixed mode 32-bit)
> Sun Microsystems Inc. java version "1.6.0_10" Java(TM) SE Runtime Environment
> (build 1.6.0_10-b33) Java HotSpot(TM) Client VM (build 11.0-b15, mixed mode)
> Sun Microsystems Inc. java version "1.5.0_16" Java(TM) 2 Runtime Environment,
> Standard Edition (build 1.5.0_16-b02) Java HotSpot(TM) Client VM (build
> 1.5.0_16-b02, mixed mode, sharing)
> Reporter: Ole Solberg
> Assignee: Dag H. Wanvik
> Priority: Minor
> Attachments: derby-4246a.diff, derby-4246a.stat
>
>
> testReplication_Local_3_p5_DERBY_3878(org.apache.derbyTesting.functionTests.tests.replicationTests.ReplicationRun_Local_3_p5)junit.framework.AssertionFailedError:
> Got -1 XRE11 DERBY SQL error: SQLCODE: -1, SQLSTATE: XRE11, SQLERRMC: Could
> not perform operation 'stopSlave' because the database
> 'C:\cludev\jagtmp\autoderbyN_regression\suitesAll_7\log\db_slave\wombat' has
> not been booted.. Expected XRE42
> at
> org.apache.derbyTesting.functionTests.tests.replicationTests.ReplicationRun.assertException(ReplicationRun.java:3388)
> at
> org.apache.derbyTesting.functionTests.tests.replicationTests.ReplicationRun_Local_3_p5.testReplication_Local_3_p5_DERBY_3878(ReplicationRun_Local_3_p5.java:96)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at
> org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:106)
> at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
> at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
> at junit.extensions.TestSetup.run(TestSetup.java:25)
> See e.g.
> http://dbtg.thresher.com/derby/test/Daily/jvm1.6/testing/testlog/vista/778182-suitesAll_diff.txt
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
