[
https://issues.apache.org/jira/browse/DERBY-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723090#action_12723090
]
Dag H. Wanvik commented on DERBY-4272:
--------------------------------------
Thanks for thew new patch, Hiranya!
A small comment to your answer to the previous patch:
> I think the old doSchemas method does the same. I just took the logic from
> there. I noticed that when the "APP" schema is not skipped a bunch of
> unnecessary schemas get included in the graph. So I guess the correct
> behavior is to skip it?
I think the schema creation is skipped in the old code due to the fact
that the user's schema will be automatically created the first time a
database object is created (and no explicit schema is given), and when
authentication is *not* enabled, the default schema will be APP.
However, this auto-create function applies also when authentication is
enabled. So, when authentication on, the "skipping" should, if we
decide to not create the schemas explicitly, apply to all user
schemas. I think we might as well create the schemas explicitly for
clarity.
> SQL Authorization Support for dblook
> ------------------------------------
>
> Key: DERBY-4272
> URL: https://issues.apache.org/jira/browse/DERBY-4272
> Project: Derby
> Issue Type: Improvement
> Components: Tools
> Environment: Any
> Reporter: Hiranya Jayathilaka
> Attachments: DERBY-4272-changes-u1.txt, DERBY-4272-changes-u2.txt,
> DERBY-4272-u1.patch, DERBY-4272-u2.patch
>
>
> Currently dblook suffers from two major shortcomings.
> 1. dblook doesn't take the object dependencies into consideration when
> generating DDL scripts
> 2. dblook doesn't have any support for SQL authorization
> I intend to fix these two issues and improve dblook so that the DDL scripts
> generated by dblook can be executed without errors under all conditions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
