[
https://issues.apache.org/jira/browse/DERBY-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747827#action_12747827
]
Knut Anders Hatlen commented on DERBY-4338:
-------------------------------------------
>From getNonCommentToken():
+ case '=': //
+ case '?': //
It looks like you intended, but forgot, to write comments for those two cases.
For extra credit, you could also add a javadoc comment describing
getNonCommentToken(). Though, sadly, describing an internal method in a comment
will break the established pattern in that class... :(
> Network client raises error "executeQuery method can not be used for update"
> when sql is preceded by /* */ comments
> -------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-4338
> URL: https://issues.apache.org/jira/browse/DERBY-4338
> Project: Derby
> Issue Type: Bug
> Components: Network Client
> Affects Versions: 10.4.1.3, 10.4.2.0, 10.5.1.1, 10.5.2.0, 10.5.3.0
> Reporter: Will Gomes
> Assignee: Dag H. Wanvik
> Fix For: 10.6.0.0
>
> Attachments: derby-4338-a.diff, derby-4338-a.stat, derby-4338-b.diff,
> derby-4338-b.stat
>
>
> Network derby client does not properly detect a sql select statement preceded
> by /* */ comments. As a result the sql appears to be detected as an update
> statement, and results in the following error:
> org.apache.derby.client.am.SqlException: executeQuery method can not be used
> for update.
> at
> org.apache.derby.client.am.Statement.checkForAppropriateSqlMode(Unknown
> Source)
> at org.apache.derby.client.am.PreparedStatement.flowExecute(Unknown
> Source)
> at org.apache.derby.client.am.PreparedStatement.executeQueryX(Unknown
> Source)
> The problem appears to be in Statment.parseSqlAndSetSqlModes(), which only
> appears to check for "--" style comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
