[ 
https://issues.apache.org/jira/browse/DERBY-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750738#action_12750738
 ] 

Dag H. Wanvik commented on DERBY-4355:
--------------------------------------

Very cool! Thanks for this finding, Knut! Hope the tests prove that we can add 
this feature to our list!

Nit: 
* sqlgrammar.jj 
  The argument: 
     "onClause, // should be null" 

   I think I'd prefer to do it the other way around, i.e.
     "null, // onClause not used for cross join"

* messages.xml:
  :
  <name>42Y14</name>
               <text>A join specification is not allowed with the '{0}' 
clause.</text>

Why not say "Cross join" rather than "a join"? Do you foresee that the error 
message will be used for other kind of joins later?


> Implement CROSS JOIN
> --------------------
>
>                 Key: DERBY-4355
>                 URL: https://issues.apache.org/jira/browse/DERBY-4355
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>         Environment: any
>            Reporter: Bernt M. Johnsen
>         Attachments: cross.diff
>
>
> Implement the CROSS JOIN syntax
> SELECT * from t1 CROSS JOIN t2;
> as an alternative syntax to
> SELECT * FROM t1, t2; 
> This should be pretty straight forward and ease the migration of SQL code to 
> Derby.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to