[ 
https://issues.apache.org/jira/browse/DERBY-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754180#action_12754180
 ] 

Rick Hillegas commented on DERBY-3501:
--------------------------------------

Thanks for the great spec, Francois. I have some comments:

o It would be nice to have TOC entries for the following sections: Assumptions, 
Requirements, Replication MBean, and Attributes.

o There's a Javadoc entry in the TOC but no corresponding section further down.

o I would recommend changing the names of some of the attributes:

 - Master attributes:

   HostName -> SlaveHostName
   PortNumber -> SlavePortNumber
   LastInstant -> LastLogInstant
   LastShipped -> LastLogChunkShipped

 - Slave attributes:

   HostName -> MasterHostName
   LastInstant -> LastLogInstant
   LastReceived -> LastLogChunkReceived


o In "JMX Client API and ReplicationMBean Access", did you intend for the last 
line of the first code block to appear in a bigger font and to be split off 
from the previous line?

o Could you give us an example of how to use the ping feature?

o I agree that writing a VisualVM plugin for Derby would be very useful. You 
may have some idea of how hard that is--I don't! I don't know what the 
licensing issues are for such a plugin so I can't say whether this work is even 
possible for our Apache community. Provided that there are no intractable 
licensing issues, I think that this work falls inside the Derby charter--but 
other community members may have other opinions.


o Public API - The existing MBeans are documented in our public api in the 
org.apache.derby.mbeans package. I think that we should document this new MBean 
there too.


> Implement a JMX replicationMBean for monitoring of replication.
> ---------------------------------------------------------------
>
>                 Key: DERBY-3501
>                 URL: https://issues.apache.org/jira/browse/DERBY-3501
>             Project: Derby
>          Issue Type: Improvement
>          Components: JMX
>    Affects Versions: 10.6.0.0
>            Reporter: Bernt M. Johnsen
>            Assignee: Francois Orsini
>         Attachments: ReplicationMonitoring_JMX_FS_v0_1.html
>
>
> Imlement a replicationMBean for monitoring of replication. Example attributes
> - master/slave state
> - replication buffer usage
> - replication network traffic

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to