[ 
https://issues.apache.org/jira/browse/DERBY-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777865#action_12777865
 ] 

Knut Anders Hatlen commented on DERBY-4424:
-------------------------------------------

Does anyone know what this warning is supposed to tell us?

One small concern I have with the patch, is that I'm not sure it preserves the 
intention of the runtime statistics tests. The new test only checks that the 
plans contained a table scan and did not contain a distinct scan. The comments 
in the original test seem to indicate that the intention was to test certain 
properties of the predicates. Unfortunately, it's difficult to know exactly 
which properties of the predicates to check, since the comments are rather 
vague. One of the comments is more specific, though, and says "make sure 
predicates are null tolerant", but the new test only checks the results from 
the query. I think "null tolerant" means we should check that the predicates 
have the property "Ordered nulls: false".

> Convert outerjoin.sql into JUnit
> --------------------------------
>
>                 Key: DERBY-4424
>                 URL: https://issues.apache.org/jira/browse/DERBY-4424
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: OuterJoinTest.diff
>
>
> Conversion of the outerjoin test into JUnit

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to