[ 
https://issues.apache.org/jira/browse/DERBY-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781981#action_12781981
 ] 

Kim Haase commented on DERBY-4153:
----------------------------------

Thanks for working on this, Bryan. I think Rick Hillegas knows the most about 
security policy files, so you may have to wait till after Thanksgiving for 
complete info on that.

Here are a few comments (non-technical as usual):

radminconfigdb2jdrdatracedirectory.dita (derby.drda.traceDirectory property):

It seems as if, for these properties, any additional information is provided in 
the introductory section -- the Default section is used only for a terse 
statement of the default. Also, the new material seems to apply to an 
explicitly set property rather than to the default value. So it should be 
moved, probably to that first section. (Or maybe the Syntax section.)

tadminadv804410.dita (Turning on the trace facility):

I'm glad you noticed that 2 and 3 are alternatives, not sequential steps. It's 
good to have that corrected.

You may have noticed that our DITA processor pays no attention to those <info> 
tags. It might be a good idea to make both sets into <p> tags to break up the 
information, because otherwise they just get munged into one paragraph.

This isn't in the part you are adding, but you may have noticed that there 
seems to be a missing space on the second line of the NetworkServerControl 
syntax, between the > and the [. It would be great if you could put that in.

Both topics:

We're not very consistent about the proper font for filenames (derbynet.jar) -- 
particularly in this book it varies from the <codeph> tag to the <i> tag to the 
<filepath> tag (the last is ignored by our DITA processor for the HTML frames 
version; it only works in the PDF and HTML book versions). So take your pick ...

Since DIRECTORY and TRACE DIRECTORY in the security policy lines are meant to 
be replaceables rather than literals, you might want to follow the customary 
usage here and put them in lowercase and italics, and make the second into one 
word (tracedirectory seems most consistent with others in this section).

You might want to put a colon at the ends of the permission lines -- from other 
examples, this seems to be needed.

You might also add an xref to the topic "Customizing the Network Server's 
security policy", tadminnetservcustom.dita. 

> Document that starting with 10.5 network server will attempt to create the 
> trace directory if it does not exist
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4153
>                 URL: https://issues.apache.org/jira/browse/DERBY-4153
>             Project: Derby
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 10.6.0.0
>            Reporter: Kathey Marsden
>            Assignee: Bryan Pendleton
>            Priority: Minor
>         Attachments: docs.diff, radminconfigdb2jdrdatracedirectory.html, 
> tadminadv804410.html
>
>
> Starting with 10.5, Network server will attempt to create the trace directory 
> (and any parent directories) if they do not exist.  This will require that 
> the derbynet.jar permit verification of the existence of the named trace 
> directory and all necessary parent directories.  For each directory created, 
> the policy will require
> permission java.io.FilePermission "<directory>", "read,write"
> and the trace directory will require
> permission java.io.FilePermission "<trace directory>${/}/-", "write"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to