[ 
https://issues.apache.org/jira/browse/DERBY-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835329#action_12835329
 ] 

Kristian Waagan commented on DERBY-4548:
----------------------------------------

No really any opinions, I obviously don't know enough about how ant is supposed 
to work.

I did try some variations as well, and I have to say I only got confused.  At 
one point I was convinced there is something wrong with our targets setting the 
sanity...
Some of my scripts use -f propertyfile and that seems to change the behavior (I 
think you mentioned this). I only use different property files when building 
older releases, so my requirements are minimal (my single build script detects 
the Derby version and uses the appropriate property file).

If you're confident enough of the current approach, and the change doesn't 
cause trouble for other people, I'd say it's fine.
Putting something in place that fits perfectly for all use-cases might be hard 
:)

+1

> would like an alternative location for ant.properties
> -----------------------------------------------------
>
>                 Key: DERBY-4548
>                 URL: https://issues.apache.org/jira/browse/DERBY-4548
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>    Affects Versions: 10.0.2.2, 10.1.3.3, 10.2.2.1, 10.3.3.1, 10.4.2.1, 
> 10.5.3.1, 10.6.0.0
>            Reporter: Myrna van Lunteren
>         Attachments: DERBY-4548.diff
>
>
> The current build.xml directs ant to look for a file ant.properties in 
> user.home. 
> This can get confusing when you have multiple versions on the same machine.
> I've worked around this in the past by pointing ant at other directories with 
> -Duser.home=..., but it would be easier to have another place set up - I 
> don't really like changing user.home.
> We could add another line to build.xml, e.g., for trunk's current build.xml:
> @@ -20,6 +20,7 @@
>  <!-- Set Properties -->
>    <!-- User settings -->
> +  <property file="ant.properties"/>
>    <property file="${user.home}/ant.properties"/>
>    <!-- Set property lib dir -->
>    <property name="properties.dir" value="tools/ant/properties"/>
> This would make ant look first for ant.properties in the same directory as 
> the top level build.xml, and secondly for the one in user.home.
> If the community agrees this would be ok, I'd like to make this change and 
> backport it all the way to 10.0.
> By having an additional place we'd not cause incompatibilities to other build 
> processes (except if someone has put an ant.properties file in the top of the 
> checked out tree).
> If we do this, I think it's up to the developers to ensure that there's not 2 
> ant.properties files that are conflicting. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to