[
https://issues.apache.org/jira/browse/DERBY-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835765#action_12835765
]
Sylvain Leroux edited comment on DERBY-4553 at 2/19/10 2:58 PM:
----------------------------------------------------------------
Hi Knut,
Thanks for reviewing such a critical issue ;)
I attach here a new patch for this issue:
- I agree with you to add extra constructors to ijVectorResult instead of
coding a new class.
- I have updated the comment about ijVectorResult accepting any object.
Pass derbytools ant ToolScripts test suite.
Concerning your side note, I think ij deserves some cleaning up. Both at source
level - and maybe as well in terms of functionality? According to a comment in
java/tools/org/apache/derby/impl/tools/ij/Main.java, it was first designed as a
testing tool. But ij could have some "advanced" feature to ease database
maintenance tasks.
was (Author: sleroux):
Hi Knuth,
Thanks for reviewing such a critical issue ;)
I attach here a new patch for this issue:
- I agree with you to add extra constructors to ijVectorResult instead of
coding a new class.
- I have updated the comment about ijVectorResult accepting any object.
Pass derbytools ant ToolScripts test suite.
Concerning your side note, I think ij deserves some cleaning up. Both at source
level - and maybe as well in terms of functionality? According to a comment in
java/tools/org/apache/derby/impl/tools/ij/Main.java, it was first designed as a
testing tool. But ij could have some "advanced" feature to ease database
maintenance tasks.
> In ij GETCURRENTROWNUMBER directly writeits result to output
> -------------------------------------------------------------
>
> Key: DERBY-4553
> URL: https://issues.apache.org/jira/browse/DERBY-4553
> Project: Derby
> Issue Type: Bug
> Components: Tools
> Reporter: Sylvain Leroux
> Assignee: Sylvain Leroux
> Priority: Trivial
> Attachments: DERBY-4553.patch, DERBY-4553_2.patch,
> DERBY-4553_repro.patch
>
>
> In ij, the statement GETCURRENTROWNUMBER directly write its result to output
> instead of returning it:
> Here are the faulty lines in ij.ij, method GetCurrentRowNumber():
> ...
>
> LocalizedResource.OutputWriter().println(utilInstance.getCurrentRowNumber(rs));
> return null;
> This interferes with testing - and possibly with any external tool using the
> ij.ij parser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
