[ 
https://issues.apache.org/jira/browse/DERBY-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Knut Anders Hatlen resolved DERBY-4608.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.6.0.0

Thanks Bryan! All the regression tests ran cleanly, so I committed the patch 
with revision 931189.

The wording of the THROWASSERT struck me too as somewhat too colourful. I'll 
try to come up with something more neutral and change that too.

> Unnecessary conversion of binary values to strings in SQLBinary.compare()
> -------------------------------------------------------------------------
>
>                 Key: DERBY-4608
>                 URL: https://issues.apache.org/jira/browse/DERBY-4608
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.5.3.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>             Fix For: 10.6.0.0
>
>         Attachments: isnull.diff
>
>
> SQLBinary.compare(int,DataValueDescriptor,boolean,boolean) converts the 
> values to strings in order to check whether any of them are null. The 
> isNull() method should be used instead to prevent the unnecessary conversion 
> to strings.
> See this thread on derby-user: 
> http://mail-archives.apache.org/mod_mbox/db-derby-user/201003.mbox/%3c001801cad09b$09aef650$1d0ce2...@ru%3e

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to