[ 
https://issues.apache.org/jira/browse/DERBY-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879728#action_12879728
 ] 

Kristian Waagan commented on DERBY-2419:
----------------------------------------

See DERBY-4700 for the bogus port issue.

Committed patch 3a to trunk with revision 955529.

> Tighten encapsulation of state in TestConfiguration
> ---------------------------------------------------
>
>                 Key: DERBY-2419
>                 URL: https://issues.apache.org/jira/browse/DERBY-2419
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.3.1.4
>            Reporter: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-2419-1a-alternative1.diff, 
> derby-2419-2a-alternative2.diff, derby-2419-2a-alternative2.stat, 
> derby-2419-3a-further_encapsulation.diff, derby-2419-refactor-01.diff
>
>
> Parts of the state of TestConfiguration has been made public, which they 
> should not be; DEFAULT_PORT and DEFAULT_HOSTNAME.
> Using these directly from the outside can cause settings overridden by the 
> user to be ignored by tests. Further, a test should not care if the host/port 
> it uses is the Derby default or the values set by the user running the test.
> To obtain a hostname and  a port number, use the methods getPort and 
> getHostName in TestConfiguration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to