[
https://issues.apache.org/jira/browse/DERBY-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lily Wei reopened DERBY-3852:
-----------------------------
Reopen to 10.5 back port
> J2EEDataSourceTest may ignore some failures
> -------------------------------------------
>
> Key: DERBY-3852
> URL: https://issues.apache.org/jira/browse/DERBY-3852
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.5.1.1
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Fix For: 10.6.1.0
>
> Attachments: assert.diff
>
>
> I noticed that the method testConnectionErrorEvent() in J2EEDataSourceTest
> had many occurrences of code that was structured like this:
> try {
> // do something with a connection
> } catch (SQLException e) {
> assertSQLState("...", e);
> }
> This code will only fail if an unexpected exception is thrown, not if the
> code in the try block fails to throw any exception at all.
> It may be that we can fix this by adding a call to fail() at the end of each
> try block. It may also be the case that the code is written like this because
> it is expected to throw exception with the embedded driver and succeed with
> the client driver (or the other way around). If the latter is the case, this
> should be made explicit, for instance by writing it like this:
> try {
> // do something with a connection
> assertFalse(usingEmbedded(), "should have failed with the embedded
> driver");
> } catch (SQLException e) {
> if (!usingEmbedded()) {
> throw e;
> }
> assertSQLState("...", e);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
