[
https://issues.apache.org/jira/browse/DERBY-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887688#action_12887688
]
Knut Anders Hatlen commented on DERBY-4715:
-------------------------------------------
Thanks for making these improvements, Lily. A couple more comments to the
latest patch:
- The javadoc for jarClassPath() is a little unclear. I don't understand what's
meant by "the path of string" or by "the string of jar file".
- The javadoc for buildJvmVersion() should make it clear that it returns values
of system properties that identify the JVM.
- buildJvmVersion() has a @param tag, but the method has no parameters.
- Now that we add a newline character between each property, there's no need to
append " " (one space) to each property value.
- If jarClassPath() had taken a Class argument instead of a String argument,
and we called it like "jarCPath = jarClassPath(getClass());", there would be no
need to call Class.forName(), and we could remove the catch block for
ClassNotFoundException.
> Write jvm information and path of derby.jar to derby.log
> --------------------------------------------------------
>
> Key: DERBY-4715
> URL: https://issues.apache.org/jira/browse/DERBY-4715
> Project: Derby
> Issue Type: Bug
> Components: Miscellaneous
> Affects Versions: 10.6.1.0
> Reporter: Lily Wei
> Assignee: Lily Wei
> Priority: Minor
> Fix For: 10.7.0.0
>
> Attachments: DERBY-4715-1.diff, DERBY-4715-2.diff, DERBY-4715-3.diff,
> DERBY-4715-4.diff, derby.log
>
>
> The bug is part of DERBY-1272. In production environment, derby.jar can be
> located different than the derbyclient.jar It can be easier if we have jvm
> version information and path of derby.jar are in the derby.log
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
