[
https://issues.apache.org/jira/browse/DERBY-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898027#action_12898027
]
Myrna van Lunteren commented on DERBY-4765:
-------------------------------------------
Thanks for this patch!
These are my comments:
- the old test was activated from NetHarnessTest.java. You can see there, that
it cannot run with J2ME.
This needs to be preserved. You need to add the appropriate check - if
(JDBC.vmSupportsJDBC3()) - to the suite() method, and it needs to go into a
special section, with comments, in derbynet._Suite.java
- I don't see that there's any checking done for a successful start of the
networkserver. This can be accomplished by calling NetworkServerTestSetup.
waitForServerStart(NetworkServerControl networkServerController)
nits:
- the old test needs to be removed from NetHarnessTest.java
- we've lost the comment of DERBY-1466. It's an explanation of why there's no
setting of setting of 'autoflush'. I think it makes sense to preserve that
comment.
> Convert
> "org.apache.derbyTesting.functionTests.tests.derbynet.DerbyNetNewServer" to
> junit.
> ------------------------------------------------------------------------------------------
>
> Key: DERBY-4765
> URL: https://issues.apache.org/jira/browse/DERBY-4765
> Project: Derby
> Issue Type: Task
> Components: Test
> Reporter: Yun Lee
> Assignee: Yun Lee
> Attachments: derby-4765.patch, derby-4765.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
