[ 
https://issues.apache.org/jira/browse/DERBY-268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Matrigali updated DERBY-268:
---------------------------------


to add history to this feature.  Truncate table was originally implemented as a 
prototype and the current state of the code never went through the expected 
code review, testing, and planning for release.   Partly the reason was the 
standard.  But because of the standard it was never "finished".  Just because 
it passes the existing tests does not mean the current code is right, there was 
very minimal testing effort originally.  It is especially likely that the 
existing code may be missing updates that subsequent features added since the 
original code might need.  

One should not assume that "hidden code" will just work by enabling it.

Has anyone read through the existing code and verified it looked right before 
just doing the parser change?  Unfortunately the hardest bugs to find when 
enabling "dead" code is finding
the code that is missing due to changes since the dead code was disabled.  I 
didn't see anything obvious, I read the code to make sure it was not going to 
reintroduce db corruption of DERBY-4677.

I would suggest more testing and at least making this feature high for buddy 
testing before releasing it.  Maybe look at the ddl testing for offline 
compress table and make sure the tests also work for truncate table.

> Add Support for truncate table
> ------------------------------
>
>                 Key: DERBY-268
>                 URL: https://issues.apache.org/jira/browse/DERBY-268
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Lance Andersen
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>         Attachments: derby-268-01-ab-enableForInsaneBuilds.diff, 
> Derby-268.diff
>
>
> Adding support for truncate table command will aid to portability

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to