[
https://issues.apache.org/jira/browse/DERBY-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991937#comment-12991937
]
Knut Anders Hatlen commented on DERBY-5011:
-------------------------------------------
Thanks, Dave. The fix looks correct to me. I don't think this bug will ever
cause any problems seen by the users. The only thing that happens is that the
state machine considers the second '-' in '--' as part of the comment and
ignores it, which is fine. But it's still good to have it fixed.
Another issue with this code is that it sets tokenFound = "/" if there are no
more characters after the first '-'. I think this is a copy/paste error from
the case for "/*", and it should have set tokenFound to "-" instead. But again,
this doesn't really cause any problems, since the only tokens we care about
when calling this method are "select", "values", "insert", "update", "delete"
and "call".
Dag, you probably know this code better. Does the above analysis sound about
right?
> [patch] fix bad attempt at incrementing a variable
> --------------------------------------------------
>
> Key: DERBY-5011
> URL: https://issues.apache.org/jira/browse/DERBY-5011
> Project: Derby
> Issue Type: Bug
> Components: Network Client
> Affects Versions: 10.7.1.1
> Reporter: Dave Brosius
> Priority: Trivial
> Fix For: 10.8.0.0
>
> Attachments: fix_bad_increment.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> code does
> idx = idx++;
> but this does absolutely nothing
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
