[
https://issues.apache.org/jira/browse/DERBY-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003361#comment-13003361
]
Houx Zhang commented on DERBY-4443:
-----------------------------------
It's a good suggestion, Bryan.
In fact, I have tried to do some unit testing before submitting the patch.
However, I've found neither of the four methods which are affected in this
patch is called through out the derby project. Furthermore there is not a test
class named with "SystemProceduresTest". So, I'm puzzled where to add the test
cases.
Please give a further advice to help me advance!
Thanks a lot!
> Wrap rollback in exception handlers in try-catch
> ------------------------------------------------
>
> Key: DERBY-4443
> URL: https://issues.apache.org/jira/browse/DERBY-4443
> Project: Derby
> Issue Type: Bug
> Components: Demos/Scripts, Documentation, Eclipse Plug-in, JDBC,
> Network Client, Network Server, Replication, Services, SQL, Test, Tools
> Affects Versions: 10.5.3.0
> Reporter: Aaron Digulla
> Labels: derby_triage10_8
> Attachments: DERBY-4443.patch
>
>
> Avoid this pattern everywhere:
> }catch(SQLException se){
> //issue a rollback on any errors
> conn.rollback();
> throw se;
> }
> because an error in rollback will shadow the original exception.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
